Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

calcite-action-group - Actions are cut off in Safari when action group has fixed overlay positioning in a panel #8028

Closed lboyd93 closed 4 months ago

lboyd93 commented 1 year ago

Check existing issues

Actual Behavior

In Safari, the grouped actions in the drop down are cut off when expanded. 2023-10-18_11-22-39

Expected Behavior

The grouped actions should not be cut off, but they should overlay the rest of the calcite panel. This is the behavior in Chrome and Firefox. 2023-10-18_11-22-55

Reproduction Sample

https://codepen.io/driskull/pen/MWZNOMR?editors=1000

Reproduction Steps

  1. Open sample in Safari: https://codepen.io/driskull/pen/MWZNOMR?editors=1000
  2. Select the grouped actions drop down. Note it only shows four actions and it's all within the panel.
  3. Open the sample in chrome and repeat step 2. Note all the actions are shown and it overlaps the panel.

Reproduction Version

1.9.2

Relevant Info

macOS 13.6 (22G120) Safari Version 17.0 (18616.1.27.111.22, 18616)

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

This issue impacts the ArcGIS Online Map Viewer and custom ArcGIS Maps SDK for JavaScript applications used in Safari that utilize popups with many actions. The actions listed at the end of the group will be unusable.

cc @driskull

Example of JS SDK application: https://codepen.io/laurenb14/pen/bGOXayX?editors=1000

Calcite package

Esri team

ArcGIS Maps SDK for JavaScript

driskull commented 1 year ago

This one looks like a Maps SDK issue. I think we can close it.

driskull commented 1 year ago

Reopening, seems like it does happen in safari within a flow/panel

asangma commented 1 year ago

I've done some testing. It seems like it may be coming from the overflow: hidden rule in CalcitePanel.

I have a Codepen in which I turn off the overflow: hidden on Panel and it seems to work. I'm not sure if it breaks other stuff though.

https://codepen.io/mtb-alan/pen/poGJJaM?editors=0100

github-actions[bot] commented 12 months ago

Installed and assigned for verification.

geospatialem commented 11 months ago

@DitwanP Can you verify the issue above in the Safari browser with the example above with next?

DitwanP commented 11 months ago

Verified on Safari

Screenshot 2023-11-20 at 11 35 44 AM
geospatialem commented 8 months ago

Reopening from the revert above https://github.com/Esri/calcite-design-system/issues/8028#ref-pullrequest-2126306731

jcfranco commented 8 months ago

Confirmed this is still an issue with the latest: https://codepen.io/jcfranco/pen/rNbNKgx?editors=1000.

Here are Matt's findings from the revert PR. 🕵️

github-actions[bot] commented 5 months ago

Installed and assigned for verification.

DitwanP commented 4 months ago

🍯 Verified locally on dev

Screenshot: (Safari - Version 17.5) image