Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

List Item Group #8039

Closed asangma closed 6 months ago

asangma commented 1 year ago

Check existing issues

Description

Some UI enhancement requests for ListItemGroup.

Background color and hover states

ListItemGroup uses foreground-2. This can conflict with anything that use ui-background. It also makes for weird hover states. Suggest foreground-1 or even transparent.

Current

background color problem

Current hover state

background color hover problem

Using foreground-1 or transparent

background color suggestion

background color hover solution

Alignment

Labels don't align. This might be from the selection border? alignment

Caret spacing

It appears that the spacing is 1rem start and 0.75rem end. Visually, this feels imbalanced.

caret spacing

Expand/collapse versus selection

The hit area for expand/collapse versus selection is confusing. Suggest visually distinguishing between the two hover states.

expands hit

This may require updating the "invisible" selection border color on hover.

Acceptance Criteria

Not breaking stuff.

Relevant Info

No response

Which Component

List Item Group

Example Use Case

SDK LayerList, BasemapLayerList, and TableList.

Priority impact

p3 - want for upcoming milestone

Calcite package

Esri team

ArcGIS Maps SDK for JavaScript

asangma commented 1 year ago

cc @driskull

macandcheese commented 1 year ago

From a UI standpoint, IMO the List Item Group is an extremely heavy element, the combination of vertical height and font weight make these Lists quite ... large. I guess this applies to the items themselves, not just the groups. Maybe we can look to reduce the height of all of these by a bit. Over an entire UI this could be a drastic improvement.

asangma commented 1 year ago

@macandcheese Agreed! :)

ashetland commented 8 months ago

This Figma file covers designs for this issue and multiple related design revisions for List. cc @driskull

github-actions[bot] commented 8 months ago

cc @geospatialem, @brittneytewks

github-actions[bot] commented 7 months ago

Installed and assigned for verification.

DitwanP commented 6 months ago

🍯 Verified on 2.8.0-next.10