Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

stepper: add tokens for responsive layout #8174

Closed anveshmekala closed 9 months ago

anveshmekala commented 1 year ago

Check existing issues

Description

Stepper component is using fixed min-width length to determine displaying single item vs all items as part of responsive layout enhancement. Having these values in design tokens helps users to enhance the values as required.

Acceptance Criteria

  1. Create tokens for min-width value for each scale.
  2. Use the tokens in stepper component to access the min-width of stepper-item per scale.

Relevant Info

No response

Which Component

calcite-stepper

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

Esri team

N/A

geospatialem commented 11 months ago

Could be considered as part of the efforts of https://github.com/Esri/calcite-design-system/issues/7180

geospatialem commented 11 months ago

In addition to the above, we should also add context to the Stepper doc page regarding the width of the component, or container width, which includes:

Knowing this context, can help developers decide if they would like to enable the single view mode or not.

cc @DitwanP

anveshmekala commented 9 months ago

We longer need tokens for min-width of stepper-item as per #8461. Can we close this one? @geospatialem , @DitwanP

github-actions[bot] commented 9 months ago

Installed and assigned for verification.

geospatialem commented 9 months ago

We longer need tokens for min-width of stepper-item as per #8461. Can we close this one? @geospatialem , @DitwanP

Thanks @anveshmekala - marked the issue as installed pending verification. cc @DitwanP we may need an updated doc ref in our doc repo, more context above in https://github.com/Esri/calcite-design-system/issues/8174#issuecomment-1858578163.

anveshmekala commented 9 months ago

We longer need tokens for min-width of stepper-item as per #8461. Can we close this one? @geospatialem , @DitwanP

Thanks @anveshmekala - marked the issue as installed pending verification. cc @DitwanP we may need an updated doc ref in our doc repo, more context above in #8174 (comment).

Don't think the min-width's are documented. We no longer use default min-width in stepper. As part of https://github.com/Esri/calcite-design-system/issues/8461 fix, imposing min-width is removed irrespective of the layout value.

geospatialem commented 9 months ago

Closing as no longer valid per Anvesh's comment above in https://github.com/Esri/calcite-design-system/issues/8174#issuecomment-1949305383.