Closed driskull closed 6 months ago
This needs to go to design first.
@geospatialem would it be possible to prioritize this? It's causing come confusion and unpredictable behavior trying to drag items into group layers in the new JavaScript SDK layer list widget.
@driskull Didn't this get merged into v.2.0? Should it have also been part of v1.11.0?
I did a quick fix but this needs a proper design.
I think this could be solved by #7100 and indenting the whole item.
Thought I'd mention this not only affects the JS SDK, but the applications that use our SDK like Map Viewer, Experience Builder and Instant Apps.
Thought I'd mention this not only affects the JS SDK, but the applications that use our SDK like Map Viewer, Experience Builder and Instant Apps.
Yes, this is a high priority issue for Map Viewer
Hey @sagewall and @zaramatheson is there something that @driskull's quick fix isn't addressing? Can you show us demo of the problem? I'm working on some related List designs, but I want to make sure I/we fully understand what's causing this issue. We might be able to expedite a better fix.
Sure, Currently it's impossible to move an item down the list under an open group layer without adding it to the group. If you move a layer up from further down the list, there isn't a way to add it to the group.
https://github.com/Esri/calcite-design-system/assets/2636825/fc2461f6-3218-4267-8004-47eaac5951d5
Should we rename this issue "difficulty dragging into child list", I didn't notice the "empty" part in the name?
This is super helpful. Thank you! Renaming might make sense. It doesn't look like "empty" is the issue here.
This Figma file covers multiple related design revisions for List and includes a section for improvements to sorting. @driskull we've outlined our ideal for this, but we intend final details to be hammered out once we start building this and the related changes.
cc @geospatialem, @brittneytewks
@ashetland @jcfranco when we deprecate the "classic" mode, which will become the default mode? "flat" or "nested"?
My gut feeling is "nested" becomes the default, but I think @jcfranco also mentioned letting metrics decide this?
@driskull Confirming that all we need to do for this issue is indent the entire item? We have some other possible improvements we'd like to test, but they could be separate from this issue.
Yes, thanks @ashetland
@ashetland PR ready for your review.
Installed and assigned for verification.
🍡 Verified on 2.8.0-next.10
https://github.com/Esri/calcite-design-system/assets/60022782/0ab7e607-1095-44e3-9a86-fb4947ac55f1
Check existing issues
Description
Its difficult to drag a list item into an empty list because the list takes up no space.
It would be nice if an empty list had some reserved space area to drop items.
Acceptance Criteria
Easier to drag into an empty list
Relevant Info
https://codepen.io/driskull/pen/WNPzLdK?editors=1000
Which Component
list
Example Use Case
See relevant info
Priority impact
p3 - want for upcoming milestone
Calcite package
Esri team
ArcGIS Maps SDK for JavaScript