Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
280 stars 77 forks source link

Shell-panel : rename `position` property to `actionBarPosition` #8306

Open anveshmekala opened 9 months ago

anveshmekala commented 9 months ago

Description

Currently, calcite-shell-panel has property position which is used to tweak the slotted calcite-action-bar placement. As part of the proposed refactor the property will be renamed to actionBarPosition since it is affecting the position of slotted calcite-action-bar only.

Proposed Advantages

Makes the property more meaningful and understandable. Be consistent with existing pattern of {elementName}Position

Which Component

calcite-shell-panel

Relevant Info

No response

Calcite package

anveshmekala commented 9 months ago

The prop will be deprecated first and removed in later milestones.

geospatialem commented 1 month ago

Added a research spike and design to determine the best path forward for consistency and understandability for users, while also considering what should be supported and direction in the future.

SkyeSeitz commented 2 weeks ago

Updated proposal:

Deprecate the position and layout props and set position by the Shell according to what slot the Shell Panel lives in.

panel-top position="start", layout="horizontal" panel-bottom position="end", layout="horizontal" panel-start position="start", layout="vertical" panel-end position="end", layout="vertical"

@anveshmekala

github-actions[bot] commented 2 weeks ago

cc @geospatialem, @brittneytewks