Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

text-area `disabled` state low-contrast #8374

Closed nwhittaker closed 6 months ago

nwhittaker commented 11 months ago

Check existing issues

Actual Behavior

The disabled state for a text-area element is very low contrast and inconsistent with the disabled state of the other input components.

image

Expected Behavior

I was expecting the colors used in the text-area's disabled state to match the colors used in the inputs' disabled state.

image

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/ZEwwwMy

Reproduction Steps

Visit the repro. and visually compare the disabled components.

Reproduction Version

2.0.0

Relevant Info

Inspecting the calcite-text-area component, it looks like a 0.5 opacity is getting doubly applied. Once to the :host and once to the :host textarea element.

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

Esri team

ArcGIS Field Apps

geospatialem commented 10 months ago

Adding design folks to this issue to determine next steps and evaluation across the components in alignment with textarea.

ashetland commented 6 months ago

@geospatialem Next steps are to remove the double opacity, matching the above expected behavior. If there are no other questions, we should be able to mark this ready for dev.

geospatialem commented 6 months ago

@geospatialem Next steps are to remove the double opacity, matching the above expected behavior. If there are no other questions, we should be able to mark this ready for dev.

@ashetland Awesome, think we'd just need a Figma url, or screenshot of the expected outcome then this is ready for dev 🚀 .

github-actions[bot] commented 6 months ago

cc @geospatialem, @brittneytewks

github-actions[bot] commented 6 months ago

Installed and assigned for verification.

DitwanP commented 6 months ago

🍬 Verified on 2.9.0-next.18