Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

calcite action with slot as header-menu-actions no longer calls onclick #8628

Closed previnWong closed 10 months ago

previnWong commented 10 months ago

Check existing issues

Actual Behavior

If you have a calcite-action with a slot as "header-menu-actions", the onclick event does not fire. If you change to "control" the onclick fires. But I lose the drop down menu that it creates.

click no longer works (header-menu-actions) image

click works (control) image

Expected Behavior

action with slot "header-menu-actions" use to fire the onclick event.

Reproduction Sample

https://codepen.io/pwongEsri/pen/MWxmbRr?editors=1000

Reproduction Steps

switch the slot in line 16 - from control to header-menu-actions to see the onclick event no longer fires

Reproduction Version

2.2.0

Relevant Info

Windows, Chrome

Regression?

worked on the version of calcite equal to JS Maps SDK 4.28

Priority impact

p2 - want for current milestone

Impact

Users cannot remove the item in the block, thus widget will be broken

Calcite package

Esri team

ArcGIS Solutions

github-actions[bot] commented 10 months ago

Installed and assigned for verification.

nCastle1 commented 10 months ago

Not sure if its related, but I noticed blur-related issues with the LayerList with Widgets sample. Repro app: https://zrh-app-sd-2.esri.com/arcgis-play/f/L3uf

geospatialem commented 10 months ago

Verified in 2.2.1-next.1 with https://codepen.io/pwongEsri/pen/MWxmbRr. ✔️

Not sure if its related, but I noticed blur-related issues with the LayerList with Widgets sample. Repro app: https://zrh-app-sd-2.esri.com/arcgis-play/f/L3uf

@nCastle1 Could you, or other Maps SDK folks test with Calcite 2.2.1-next.1, to determine if the fix mitigates the blur-related issues? Closing the above out, but can revisit or open a new issue if additional follow-up is needed.