Combobox Item value should not be required - Githubissues

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System

https://developers.arcgis.com/calcite-design-system/

Other

270 stars 75 forks source link

Combobox Item value should not be required #8737

Open DitwanP opened 4 months ago

DitwanP commented 4 months ago

Check existing issues

[X] I have checked for existing issues to avoid duplicates

Actual Behavior

The value prop on combobox-item is set to be required.`

Expected Behavior

The value prop on combobox-item should not be set required.

Reproduction Version

2.4.0

Priority impact

p4 - not time sensitive

Calcite package

[X] @esri/calcite-components
[ ] @esri/calcite-components-angular
[ ] @esri/calcite-components-react
[ ] @esri/calcite-design-tokens
[ ] @esri/eslint-plugin-calcite-components

Esri team

N/A

geospatialem commented 3 months ago

We should consider adding a label property, where we deprecate the textLabel property.

label should be required, where value should be optional.

Of note, if we add in a description property, the label (or "heading" takes precedence for AT).