Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

[input time zone] Update the open picker to make the ability to search more obvious #9017

Closed emmilaakso212 closed 1 month ago

emmilaakso212 commented 6 months ago

Check existing issues

Description

As a user selecting timezone values, I want to know that the field is searchable, rather than just a selection.

Acceptance Criteria

When the timezone dropdown is open:

See design in Figma

Relevant Info

Agreed upon work with Calcite team in support of time zone picker update for 24-R3.

Which Component

Timezone picker

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Calcite package

Esri team

ArcGIS Map Viewer

macandcheese commented 6 months ago

Some of the above should be possible with the existing placeholder and placeholder-icon properties.

Screenshot 2024-03-29 at 10 35 01 AM

https://codepen.io/mac_and_cheese/pen/OJGxzzB?editors=100

The placeholder has no default string - the "Select a field" from the example on the documentation site is just a suggestion.

Currently there is no ability to persist the placeholder-icon once a selection is made - we could introduce a separate icon property for this that replaces placeholder-icon post-selection - would that work?

To clarify the other ask - is that different than the current behavior of selection-mode="single"? Currently it will hide the selection and display the placeholder and placeholder-icon when the Combobox is open.

https://github.com/Esri/calcite-design-system/assets/4733155/63c289c9-8273-4fcb-8fc3-20f7a72c3553

emmilaakso212 commented 6 months ago

cc: @jcfranco

github-actions[bot] commented 5 months ago

cc @geospatialem, @brittneytewks

geospatialem commented 5 months ago

Aiming for dev implementation prior to R3 based on Online priorities - currently targeted for July. cc @emmilaakso212

github-actions[bot] commented 2 months ago

Installed and assigned for verification.

jcfranco commented 2 months ago

A few notes on the acceptance criteria:

Change default text from “Select a field” to “Search options”

The component doesn't use this text by default, but it can be customized via messageOverrides.

Add option to have custom placeholder text in the box

See note on messageOverrides above.

If custom placeholder text is longer than available space, truncate the text and show ellipsis

The component already does this, but it appears Firefox is the only one that truncates consistently. Chrome truncates on pointer down outside of the component and Safari truncates on pointer down anywhere on the page (see https://codepen.io/jcfranco/pen/wvLJExw?editors=100). I'll create a separate issue to investigate this further.

DitwanP commented 1 month ago

🍡 Verified on 2.12.0-next.4