Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
268 stars 75 forks source link

Multi-select chip group affordance enhancement #9055

Open mattdente opened 2 months ago

mattdente commented 2 months ago

Check existing issues

Description

The current multi-select chip group's affordance is not entirely clear. Rounded selection indicators could be perceived as single-select radio buttons.

image

After consulting with Adam, he proposed an enhancement for multi-selection chips where by the selection indicator is a square/box which looks more like a checkbox (i.e. a better affordance we suspect).

Screenshot 2024-04-03 at 2 18 35 PM

Acceptance Criteria

The proposed new design would function in the same way as it currently does, but instead of presenting a round selection indicator, the multi-select chips would present a square selection indicator.

Relevant Info

No response

Which Component

Chip group (https://developers.arcgis.com/calcite-design-system/components/chip-group/)

Example Use Case

In Data Pipelines, when a user "runs" a pipeline, the "run details" can produce a long list of results. We're using the multi-select chip filter to allow users to filter by run detail message type like so: chip-filter-screenshot

Priority impact

p3 - want for upcoming milestone

Calcite package

Esri team

ArcGIS Online

macandcheese commented 2 months ago

I think this would be a good improvement for system consistency. Might require a double check of https://github.com/Esri/calcite-design-system/issues/7425 to ensure the new icon glyph still works at small scales.

cc @ashetland @SkyeSeitz

ashetland commented 2 months ago

I think this would be a good improvement for system consistency. Might require a double check of #7425 to ensure the new icon glyph still works at small scales.

cc @ashetland @SkyeSeitz

Agreed. Might make sense to pair with #7425 for the double-check.

ashetland commented 1 month ago

Here's the design spec for this one https://www.figma.com/design/HB1Ollf1D1Csy2PtXJ3Hai/Chip-selection-affordance-%26-padding?node-id=501-15580&m=dev

github-actions[bot] commented 1 month ago

cc @geospatialem, @brittneytewks

mattdente commented 1 month ago

Nice. I can't tell by looking at this spec, so just want to confirm, the component will allow you to show an unselected checkbox or radio button state?

image

ashetland commented 1 month ago

@mattdente This would update the multi-select appearance. If you'd like to see an empty state in the selection-mode="single", would you be able to log a new issue?

CleanShot 2024-05-16 at 10 58 08@2x

mattdente commented 1 month ago

Thanks for clarifying, @ashetland. I do think the same affordance (unselected radio button state) for the single select group would be an improvement. If you, and @macandcheese both agree, I can write up the issue.

macandcheese commented 1 month ago

I hesitate to change the behavior of the single / single-persist modes. I think this change makes sense for multiple, where we just adjust the icon affordance used, but I'm not sure I agree it's needed in the single / single-persist.

mattdente commented 1 month ago

Makes sense. I'll stay tuned for any feedback I may see during usability studies on the single-select behavior, it may be just fine. I have no direct observations of that being a problem. It does feel inconsistent with multi-select, but perhaps that's not a problem either.