Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
282 stars 76 forks source link

Action: Create localized template for aria-label #9071

Open driskull opened 5 months ago

driskull commented 5 months ago

Check existing issues

Actual Behavior

aria-label is using a template for its string value here

https://github.com/Esri/calcite-design-system/blob/15ca10a2bbedc568951246ff57537907e257bbc2/packages/calcite-components/src/components/action/action.tsx#L302

Expected Behavior

This should use a proper localized template

Reproduction Sample

https://codepen.io/driskull/pen/NWmyeXw?editors=1000

Reproduction Steps

  1. open codepen
  2. Inspect internal element with aria-label aria-label="test (Indicator present)"

Reproduction Version

1.7.1

Relevant Info

https://github.com/Esri/calcite-design-system/pull/9051#discussion_r1551861189

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

Esri team

N/A

driskull commented 5 hours ago

@geospatialem can we move this issue until the string is available in all locales?

geospatialem commented 5 hours ago

@geospatialem can we move this issue until the string is available in all locales?

Sure, we're currently set for October, would this fit the timeline, or do we need to push to November, @driskull?

driskull commented 5 hours ago

Just whenever the strings will be there.

geospatialem commented 5 hours ago

Just whenever the strings will be there.

checked in with Anvesh and we should be on target for October, but can move this out to November if the translations are delayed.

driskull commented 5 hours ago

Sounds good!