search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
291 stars 75 forks source link

Replace `autoClosableRetainsCloseButton` alert screenshot test with e2e #9122

Open Elijbet opened 7 months ago

Elijbet commented 7 months ago

Description

Dropped autoClosableRetainsCloseButton_TestOnly in PR #9118 to be replaced with an e2e test asserting close button is retained throughout the length of close delay and closes when prompted.

Proposed Advantages

e2e test is more appropriate for this functionality

Which Component

alert

Relevant Info

No response

Calcite package

jcfranco commented 1 month ago

@Elijbet Can you link to the PR that removed the autoClosableRetainsCloseButton_TestOnly test?

Elijbet commented 1 month ago

@Elijbet Can you link to the PR that removed the autoClosableRetainsCloseButton_TestOnly test?

Yes. It's test(alert, text-area): improve layout for screenshot diffs #9118