search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
269 stars 75 forks source link

Tile directly reassigns CSS variables within the component #9278

Closed alisonailea closed 1 month ago

alisonailea commented 1 month ago

Check existing issues

Actual Behavior

Tile component tokens as CSS can not be reassigned by users because the tokens are directly assigned within the component.

Expected Behavior

As a user I should be able to give each component token new values and have those take precedence over the internal token assignments, including for classes and states

Reproduction Sample

https://codepen.io/alisonailea/pen/yLWBXbq/c1ce40abeafb2210def6108a2b745c5f

Reproduction Steps

  1. open the link
  2. observe the tile that has the class ".selected"
  3. notice the border is still blue and not red

Reproduction Version

2.8.1-next.3

Relevant Info

No response

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

No response

Calcite package

Esri team

Calcite (design)

geospatialem commented 1 month ago

@alisonailea Would the above also be closed in favor of https://github.com/Esri/calcite-design-system/issues/7180 per https://github.com/Esri/calcite-design-system/pull/9279#issuecomment-2105110408?

geospatialem commented 1 month ago

Closing in favor of #7180 as discussed in the team mid-milestone discussion and mentioned in the comment above on 5/13. cc @alisonailea