Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
270 stars 75 forks source link

[List Item] Selection padding has too much space when the List's width is reduced #9290

Closed geospatialem closed 1 month ago

geospatialem commented 2 months ago

Check existing issues

Actual Behavior

When updating from value-list to list in smaller width use cases for selections, additional padding is added, which effects the look of the component:

image

Before with value-list After with list

Expected Behavior

Replace the existing 12px padding to the right of the component's selectionAppearance of "icon" for selectionMode's of "multiple", "single" and "single-persist" to 4px with the --calcite-spacing-xxs token:

image

image

Reproduction Sample

https://codepen.io/geospatialem/pen/WNBNeNe

Reproduction Steps

  1. Open the sample
  2. Observe the padding on the left example: selection-mode="icon"
  3. Observe the padding in the other two examples
  4. This can also be observed on the documentation site samples
  5. Compare to this value-list sample

Reproduction Version

2.8.0

Relevant Info

Refer to the impact statement below.

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

Came up when the Analysis team converted their pick-list to list, where when confined to a smaller width panel, the padding takes up a considerable amount of space. They are considering reverting back to pick-list if a fix cannot be mitigated, and would have to migrate over after the breaking change release when #7100 is implemented.

Calcite package

Esri team

ArcGIS Web Analysis

github-actions[bot] commented 2 months ago

cc @geospatialem, @brittneytewks

geospatialem commented 1 month ago

cc @amring1

github-actions[bot] commented 1 month ago

Installed and assigned for verification.

DitwanP commented 1 month ago

🍡 Verified locally on hotfix

image