Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
279 stars 76 forks source link

Initialization regression in `components` output target #9468

Closed geospatialem closed 3 months ago

geospatialem commented 3 months ago

Check existing issues

Actual Behavior

As a result of upgrading from 2.8.3 to 2.8.4 there were some failing screenshot tests from internal teams. We should restore the componentDidLoad hooks to accommodate changes in initialization.

Expected Behavior

No failing screenshot tests

Reproduction Sample

https://stackblitz.com/edit/github-ojdkyo-zgju9e

Reproduction Steps

  1. Observe component's initial value set when using v1.8.3.
  2. Update package.json to use @esri/calcite-components@2.8.4. Notice value is not displayed in the input.

Reproduction Version

3.8.4

Relevant Info

Seems to pertain to be related to https://github.com/Esri/calcite-design-system/pull/9443

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

High

Calcite package

Esri team

ArcGIS Maps SDK for JavaScript

github-actions[bot] commented 3 months ago

Installed and assigned for verification.

geospatialem commented 3 months ago

Verified in 2.8.5