Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

Calcite Sheet `calciteSheetBeforeOpen` happens after the animation is done #9641

Closed hcampos-professional closed 1 month ago

hcampos-professional commented 3 months ago

Check existing issues

Actual Behavior

When the <calcite-sheet> is opened, its calciteSheetBeforeOpen event is fired only after the transition/animation has happened.

Expected Behavior

As per the documentation the event should be fired before the transition starts, and calciteSheetOpen should be called after it finishes.

Reproduction Sample

https://codepen.io/hccampos/pen/pomLvZo

Reproduction Steps

  1. Open https://codepen.io/hccampos/pen/pomLvZo
  2. Click "Open sheet"
  3. Notice that when the alert is displayed, the transition is already completed.

Reproduction Version

2.9.x

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

Esri team

ArcGIS Maps SDK for JavaScript

geospatialem commented 3 months ago

Related consistency issue for events: https://github.com/Esri/calcite-design-system/issues/9315

github-actions[bot] commented 1 month ago

Installed and assigned for verification.

DitwanP commented 1 month ago

🍡 Verified on 2.12.0-next.18 https://codepen.io/Ditwan-Price/pen/OJezmaw