Calcite slider with snap=true and step=1 can present floating point, non-integer values

RSantosGIS commented 4 months ago

Check existing issues

[X] I have checked for existing issues to avoid duplicates

Actual Behavior

The calcite slider allows users to select values that are very close to, but not quite, a round integer value. See below:

Expected Behavior

When snap=true and step=1 (or any other integer value), the slider should only change to exactly integer values (no decimal place).

Reproduction Sample

Documentation (ArcGIS Knowledge Studio / Teams chat)

Reproduction Steps

Please see the conversation in teams chat

@benelan indicated he was already aware of this issue since Slider isn't using a util that handles precision issues.

Reproduction Version

2.8

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

Everything works, but it looks unprofessional in our app. For applications where exact integer values are required, it makes the slider component unusable.

Calcite package

[X] @esri/calcite-components
[ ] @esri/calcite-components-angular
[X] @esri/calcite-components-react
[ ] @esri/calcite-design-tokens
[ ] @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Knowledge

geospatialem commented 4 months ago

@RSantosGIS Would you be able to put together a sample for us above to troubleshoot? We're trying to determine if this is React-specific.

RSantosGIS commented 4 months ago

I tried to create something in the sandbox but wasn't able to reproduce, and since Ben indicated that you guys already knew about a problem with rounding numbers I didn't pursue it further. If you need me to, I can make an issue to try to spend some more time on this for the repro case