Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
287 stars 76 forks source link

panel: add alerts slot #9772

Closed driskull closed 3 months ago

driskull commented 3 months ago

Check existing issues

Description

add alerts slot to panel to constrain alerts to the panel in question

Acceptance Criteria

alerts can be slotted into a panel and contained within that panel

Relevant Info

https://github.com/Esri/calcite-design-system/issues/7886#issuecomment-2224099221

Which Component

panel

Example Use Case

<calcite-panel>
<calcite-alert slot="alerts"></calcite-alert>
</calcite-panel>

Priority impact

impact - p1 - need for current milestone

Calcite package

Esri team

N/A

github-actions[bot] commented 3 months ago

Installed and assigned for verification.

DitwanP commented 3 months ago

@driskull Is this how it's intended to look or is it supposed to be above the buttons? Screenshot 2024-07-16 at 10 59 06 AM

driskull commented 3 months ago

Yes, that is how I intended, it is just constrained inside the panel. Maybe we should ask @SkyeSeitz and @ashetland ?

SkyeSeitz commented 3 months ago

Is the Alert slot always tied to the content inside the bounds of Panel's default slot? Or would that ever be too narrow?

image
driskull commented 3 months ago

My thinking was that it might be too narrow in some cases.

SkyeSeitz commented 3 months ago

I assumed the same and defaulted to positioned to the Panel itself. I am fine with that if no one else has any objections.

ashetland commented 3 months ago

This may be fine as a starting point and could be updated after feedback. My initial reaction is it does feel awkward covering the footer like that and might be nice if it had some margin to force it higher? But as I said, could wait for feedback on it.

driskull commented 3 months ago

Let me know what you prefer. I can make it appear over the content if that's the way we want to go.

ashetland commented 3 months ago

"Wait for feedback" is the consensus. ✅

DitwanP commented 3 months ago

🍡Verified on 2.11.0-next.11