Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
295 stars 76 forks source link

Audit `heading`/`label` props for consistency #9788

Open jcfranco opened 4 months ago

jcfranco commented 4 months ago

Description

We should look at current label prop names for consistency. The following are some common types:

  1. heading-related (suggested heading)
  2. icon text/content?(suggested `text)
  3. a11y-specific (suggested label)

There might be others, but these are some that immediately stand out.

Proposed Advantages

Consistency across item components.

Which Component

a11y

headings

icon text/content

Relevant Info

No response

Calcite package

macandcheese commented 4 months ago

Somewhat related https://github.com/Esri/calcite-design-system/issues/8926

driskull commented 1 week ago

This would be nice to do.

I did notice combobox-item has label, heading, and description but combobox-item-group only has label.

it would be nice if these were consistent.