Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
293 stars 76 forks source link

[Shell Panel] `display-mode="float-all"` has multiple bugs #9926

Open ashetland opened 3 months ago

ashetland commented 3 months ago

Check existing issues

Actual Behavior

The new float-all configuration does not match other floating UI and the resize affordance is misplaced.

Expected Behavior

Reproduction Sample

https://codepen.io/ashetland/pen/zYVZBPG?editors=1000

Reproduction Steps

  1. Open the codepen
  2. Note the sharp corners, no shadow, perimeter border, double border next to Action Bar, and the odd placement of the drag affordance

Reproduction Version

v2.11.0

Relevant Info

Related issue #7513

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

Esri team

Calcite (design)

macandcheese commented 2 days ago

In a later version, 2.13.2 - the height of the Shell Panel seems too tall, like it's not compensating for the margin when in float-all - maybe a block-size: calc(100% - 1rem); or otherwise is needed (Note - this didn't exist in the version of original Codepen, but posting here for visibility) cc @ashetland https://codepen.io/mac_and_cheese/pen/oNKrrWZ?editors=1000

Screenshot 2024-11-21 at 10 39 17 AM