Tooltips shouldn't have caret position baked in

Esri / calcite-ui-kits

This resource is deprecated.

Other

21 stars 13 forks source link

Tooltips shouldn't have caret position baked in #21

Closed patrickarlt closed 3 years ago

patrickarlt commented 5 years ago

Currently tooltips carets are baked into the Tooltip symbol making it impossible to create a tooltip where the caret faces any other way then down.

To create this (for example) I had to unlink tooltip from the library and delete the caret and then used one of the caret symbols.

macandcheese commented 5 years ago

Hm, we might be able to get away with a symbol per caret orientation. (I think) the Popper library used can position it in one of 12 positions (top left, top center, top right, etc.), maybe that's overkill for symbols but we def don't want folks to need to detach...

patrickarlt commented 5 years ago

@macandcheese you could probably just do a symbol with no caret (for the tooltip body) and 4 symbols for each caret direction and just let people compose it however they want too. I'm fine either way. I can imagine ever needing anything other then top, bottom, left, right all centered.

julio8a commented 5 years ago

Will do this ^

julio8a commented 5 years ago

Okay, I've updated on Abstract and this repository. Next, I'm going to separate the popover into its own component in the Sketch library.