search

Esri / calcite-web

Authoritative front-end development resources for Calcite design initiative. Includes extendable base components and styles, as well as a modular and efficient framework for ArcGIS properties.
http://esri.github.io/calcite-web/
Apache License 2.0
108 stars 58 forks source link

using calcite-web gem complains about missing variables.scss #301

Closed bradleywertman closed 9 years ago

bradleywertman commented 9 years ago

lib/sass/calcite-web/base/_colors.scss is looking for a variables.scss import

image

nikolaswise commented 9 years ago

Right now color is being brought in as a dependency from https://github.com/Esri/patterns-color - npm installs this and then fishes the scss out of the repo as needed.

Will need to explore how to manage a dependency like this in Ruby, or be a little more static about how we pull in colors.

paulcpederson commented 9 years ago

Sorry, that dependency was added after I set up and testing the ruby stuff. I'll look at it again.

We should probably be declaring that dependency in the gemspec and also requiring it in our lib file?

This might involve a pr to the colors repo that ensures that it can be installed as a gem.

paulcpederson commented 9 years ago

This problem also occurs when you npm link to calcite-web.

screen shot 2015-08-03 at 3 50 51 pm

I honestly have half a mind to remove this as a dependency and just update the variables by hand when they update the pallete. This is super annoying.

nikolaswise commented 9 years ago

Word, lets just do it by hand.

nikolaswise commented 9 years ago

Addressed in #305