Esri / calcite-web

Authoritative front-end development resources for Calcite design initiative. Includes extendable base components and styles, as well as a modular and efficient framework for ArcGIS properties.
http://esri.github.io/calcite-web/
Apache License 2.0
109 stars 58 forks source link

Modal toggle -- when toggle element has children, clicking on children doesn't open modal #953

Closed skitterm closed 6 years ago

skitterm commented 6 years ago

If a js-modal-trigger element has any child elements, clicking on those children will not open the modal as expected.

Modal with button trigger: https://jsbin.com/huzenujuji/1/edit?html,output -- The modal opens when clicking anywhere on the button

Modal whose button trigger has a span child: https://jsbin.com/huzenujuji/edit?html,output -- The modal soes not open when clicking on the button text, only works when clicking elsewhere on the button.

This is problematic for cases where you want to open a modal by clicking anywhere in a drop zone, for example.

paulcpederson commented 6 years ago

fixed in v1.0.3