Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

Coordinate Conversion: should clear all outputs when invalid coordinate is entered (ArcMap) #152

Closed lfunkhouser closed 7 years ago

lfunkhouser commented 7 years ago

From @elinz on December 14, 2016 16:59

NOTE: This is an enhancement, but a very critical enhancment

When you specify an invalid coordinate in the Input textbox, any previous calculated results in the Output texboxes are not cleared. The last valid output is still displayed. This is extremely dangerous as the user may not have realized they entered an invalid coordinate or did not realize that the output values didn't change from the last valid coordinate entered; they will then copy the outputs to use in other applications thinking they copied valid values.

Example: The user enters the following valid MGRS coordinate: 34PFR1459853908 The output textboxes are updated to display the output coordinates... image

Then the user enters the following invalid MGRS coordinate, either because the user was given an invalid MGRS coordinate or maybe they did a copy/paste from a report and didn't copy all the coordinates: 34KGE358193443 (it's invalid because it's missing the 10th digit in the easting/northing; perfect example of a copy/paste issue)... image

Note that the output textboxes retained the previously calculated outputs values.

This issue applies to all versions of ArcMap. Also applies to ArcGIS Pro - separate issue will be logged.

Expected Behavior

When a user enters an invalid coordinate, all output textboxes should be cleared to prevent them from copying invalid output coordinates.

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

Copied from original issue: Esri/military-tools-for-arcgis#87

Dbarnes1 commented 7 years ago

image

Verified fixed.