Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

Coordinate Conversion generating output for input values that are ambiguous (ArcMap) #209

Closed elinz closed 7 years ago

elinz commented 7 years ago

The addin is generating output for input values that are ambiguous.

Some examples, below:

@topowright FYI.

dfoll commented 7 years ago

This is what we will add to the known issues list in the documentation.

When entering integers without spaces the coordinates will be returned as inaccurate. As an example:

12 returns 1N 2E 1234 returns 4N 123E

dhagens commented 7 years ago

Ready for testing

lfunkhouser commented 7 years ago

Assigning to MT PEs and @elinz who originally submitted the issue to verify

ACueva commented 7 years ago

I'll take this one.

ACueva commented 7 years ago

New results: 2017-05-02_10-12-24 2017-05-02_10-14-36 2017-05-02_10-15-43

@elinz Mind giving this a quick once over to make sure it is now the desired output?

topowright-zz commented 7 years ago

The expected behavior would be when a user puts in a coordinate that is not clear that the tool will prompt them to allow the tool to understand what they mean.

If a user puts in 11 or 1234 or 123456 as examples the feedback should be: image

Currently this prompt happens correctly if there is a space in the inputs as an example 1 1, 12 34 , 123 456

csmoore commented 7 years ago

@kgonzago 's PR merged - ready for retest in next build

ACueva commented 7 years ago

Got this one again.

ACueva commented 7 years ago

@csmoore @topowright I'm not sure the expected behavior now: I used the same values from above. 00, 45, and 457598 throw: 2017-05-03_15-44-02

Build 1428

kgonzago commented 7 years ago

@ACueva 00, 45, and 457598 are invalid coordinates. The logic used to parse these coordinates assumes there will be a delimiter (comma, space, period, etc.) used to distinguish between x and y coordinates. 0 0 is valid but 00 (no spacing) is invalid.

ACueva commented 7 years ago

@kgonzago Makes sense. Based off your reply I believe this issue is good to go. @topowright thoughts?

topowright-zz commented 7 years ago

We need to look a the documentation.

NatalieCampos commented 7 years ago

@lfunkhouser at 2:25 pm, I tried to recheck out the "known issues for CC Addin for ArcGIS Pro" and it still says it is checked out by you.

topowright-zz commented 7 years ago

@dfoll commented on Jan 14th about listing this as a known issue. This never made it into the known issue list; however, this no longer needs to be documented. When invalid coordinates are entered a user is now prompted that the coordinate is invalid.

image