Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

Provide ability to format the Input coordinate (ArcGIS Pro) #347

Closed dfoll closed 5 years ago

dfoll commented 7 years ago

Currently you can change the format of the Input, but you can not edit the notation in the way that you can use the Advanced options in the Add New Output Coordinate dialog. This is important, because the style of the Input box also controls the way coordinates in the "List" box are shown. In short I want some control over how coordinates are formatted in the "List" box. image

Current Behavior (video attached)

Note in the video...

  1. The video starts with the Input set to MGRS, a point is collected and it displays as MGRS.
  2. DMS is added as an Output, the list still only displays as MGRS
  3. Input is changed to DMS, the List changes to DMS
  4. A point is collected and both the List and Input display DMS
  5. A second Output is added and formatted to have no separators, degree-marks, minute-marks, or second-marks
  6. The cursor then shows the newly added Output
  7. The cursor then collects another point to show that coordinates are being collected and displayed in the Output properly, according to the newly added Output, but the List retains the formatting from the Input and moves back to the "Edit Properties" button for the Input
  8. Observe that you cannot edit the formatting of the Input

Expected Behavior

You should be able to edit the Input so that the List will display the same coordinate notation as was set in the Output

image The Add New Output Coordinate dialog has a drop-down for Advanced that allows you to edit the notation,

image the Edit Properties dialog for the Input should have the same

2018-07-15_20-23-43.zip

dfoll commented 7 years ago

requested for ArcMap as well #348

topowright-zz commented 6 years ago

I do not think that this is needed. If a user is going to need to format the input format type that type can be added to the output list.

topowright-zz commented 6 years ago

@saip please place the proper label on this issue so that we understand where in the development process this issue is.

dfoll commented 6 years ago

Recently rebuilt CC build 19 and MT build 122 to test

BobBooth commented 6 years ago

On Pro. 2.3 I'm seeing an issue with certain formatted input coordinates: https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/528

kgonzago commented 6 years ago

Using build MT 126, I verified the original issue is fixed. I also verified @BobBooth's findings of custom format from the Edit Properties dialog does crash or hangs Pro.

kgonzago commented 6 years ago

I misread the issue. With @bbooth providing another pair of eyes, I confirmed @dfoll's findings of the Input textbox does not update if a custom DMS notation is entered. The list of points do update but not the coordinate in the Input textbox.

dfoll commented 6 years ago

This issue needs to be sent back to @CTLocalGovTeam. Described functionality is not working. The buttons are in place to do this but the functionality does not exist.

Additional repro steps

  1. On the Coordinate Conversion pane click the Edit Properties button next to the input text box.
  2. Highlight MGRS and Custom
  3. Expand Advanced if it is not already expanded
  4. Format the MGRS coordinate with spaces in between each piece of the MGRS coordinate (this is a supported way of supporting coordinates for the output box) image This is what the Edit Properties window looks like after making changes
  5. Click OK
  6. Click some points in the map. _Note that both the Input box and List retain old formatting.
    image
  7. Click the Edit Properties button next to the Input box again. Note that the formatting that was set in step 4 is still applied in the Edit Properties window
dfoll commented 6 years ago

@lfunkhouser this looks like an issue that was not delivered

dfoll commented 6 years ago

528 was logged which is a byproduct of this needing to be completed. When this is completed #528 should be resolved.

dfoll commented 5 years ago

Delivery of this issue introduced #527 and #528. #527 and #528 do not need to be assigned to @CTLocalGovTeam but can be used as a reference for clarification

BobBooth commented 5 years ago

Help topic is present already on Dev. Added to the CC new features list: "Supports customized display of coordinates in the input coordinates box and coordinate list." in: CC January Release page MT January Release page MT What's New image.png

BobBooth commented 5 years ago

Rebuilt Dev branch of CC and MT to verify that the PDFs have picked up the change. They have: image.png image.png