search

Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

Coordinate Conversion custom input format crashes Pro #528

Closed BobBooth closed 5 years ago

BobBooth commented 6 years ago

With Pro 2.3 and the latest CC build, if I collect a series of locations, then customize the input format, set it to MGRS and add a couple of dashes for formatting, Pro gives invalid coordinate message and crashes.

  1. Collect some locations image
  2. Customize Input coordinates.
  3. Set the Display Coordinate to MGRS
  4. Click Custom.
  5. Change the formatting in the Advanced box to have two dashes between Z and SX Click OK. image image

Asterisks also crash Pro image

If you do not have any coordinates in the list, instead of crashing, you seem to get caught up in an infinite loop of Invalid Coordinate boxes. Try to click on the map, the box pops up, but it cannot be closed. image

ArcGIS Pro 2.3.0 beta 1 build 14476 Coordinate Conversion 4.1.1.19 (latest October build)

I am also seeing similar bad behavior on Pro 2.2.0 - Adding -- to a custom MGRS input coordinate format, after locations have been added to the map, causes the Edit Properties pane (and other parts of the Pro UI) to become unresponsive after you click OK and get the Invalid Coordinate message.

BobBooth commented 6 years ago

To repro

(on ArcGIS Pro 2.3 build 14508)

Add about 15 locations to the list by clicking on the map. Change the Input format. Choose MGRS for the display format. Choose Custom. Format the MGRS string with -- as separators. image

Click OK. Get a series of invalid coordinate messages. image

Start clicking OK to close the Invalid Coordinates message boxes. Pro stops working. image

lfunkhouser commented 5 years ago

This bug was identified from the delivery of #347

dfoll commented 5 years ago

To add to what @lfunkhouser stated the PR that had this delivery was https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/518

dfoll commented 5 years ago

Using the testing build in ...\Solutions\DefenseSolutions\CoordinateConversion\Testing\CTLocalGovTeam-dev\39 this looks to be fixed.

Cases tried

Being that there is are an unknown amount of ways a user may customize the formatting. I believe this is fixed until we can find a specific case that does not work for a specific reason.

This issue was logged only explicitly against Pro, but I tested ArcMap with the above cases with no issues.

BobBooth commented 5 years ago

I tried it too, did not get the crash.