The coordinate Conversion add-in crashes Pro when importing a CSV file of coordinates

BobBooth commented 6 years ago

Current behavior:

On Pro 2.3 with the latest CC addin, when I click Import on the CC pane and browse to the CSV file attached file (NewExportTest.zip) I am prompted to choose the field to use. Neither Coordinate nor MGRS works - Pro crashes when I run the import process.

NewExportTest.zip

Expected behavior:

The add-in should allow me to import the attached file using either it's coordinates column or its MGRS column. Neither is working now.

I tested this with Pro 2.2 and the released version of CC. The MRGS field imported correctly, but I got at "please enter a valid coordinate" message if I try to import using the Coordinate field.

ArcGIS Pro 2.3.0-beta.1+build.14496 Coordinate Conversion 4.1.1.16 (9/14/18)

BobBooth commented 6 years ago

@dfoll & @lfunkhouser - this seems to be one to take to the core folks.

lfunkhouser commented 6 years ago

@BobBooth can you confirm or check how this works on the following:

[x] Released version (Sept 2018) of CC on Pro 2.2 <-- Import and export of CSV works. No Pro crash. Import MGRS works. Import of the Coordinate field results in "please enter a valid coordinate" message, but no crash. Import of sol-def-test CSV "TabletoPoint.csv" using X and Y fields works correctly.
[x] Released version (Sept 2018) of CC on Pro 2.3 <- Importing CSV tables consistently crash Pro. Retested with the sol-def-test CSV "TabletoPoint.csv" using X and Y fields, crashed. Importing single column "JustMGRS.csv" crashed Pro. Also, CSV export of list seems not to be working on Pro 2.3.
[x] Latest build of CC on Pro 2.2 <-- Import and export of CSV works. No Pro crash. Import MGRS works. Import of the Coordinate field results in "please enter a valid coordinate" message, but no crash. Import of sol-def-test CSV "TabletoPoint.csv" using X and Y fields works correctly.
[x] Latest build of CC on Pro 2.3 <- Importing CSV tables consistently crash Pro. Retested with the sol-def-test CSV "TabletoPoint.csv" using X and Y fields, crashed. Importing single column "JustMGRS.csv" crashed Pro. Also, CSV export of list seems not to be working on Pro 2.3.

I want to make sure everything has been covered before @dfoll follows up with the core team tomorrow.

@lfunkhouser @dfoll this version of Pro: ArcGIS Pro 2.3.0-beta.1+build.14496 -- has a problem with CC import/export of CSV files.

BobBooth commented 6 years ago

@lfunkhouser - I have added an issue for the "please enter a valid coordinate" problem I was seeing on Pro 2.2 https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/539

BobBooth commented 6 years ago

With today's daily, Pro 2.3.0-beta.1+build.14508 I am no longer seeing the crash. I think I had a bad build of Pro 2.3 for CSV files. Export to CSV is also working. I am still getting the "please enter a valid coordinate" message when I try to import the contents of the "coordinate" column of that table (issue https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/539), and no results, but no crash.

BobBooth commented 6 years ago

@lfunkhouser @dfoll - this is non-repro with today's daily. I've removed the other tags and added non-repro tag.

BobBooth commented 6 years ago

@dfoll & @lfunkhouser - actually, I just reproduced it again with the daily Pro 2.3 build. I can't import the MGRS-only csv. Also seeing failure to write CSV output. I'm trying to write/read from Desktop.

csmoore commented 6 years ago

I tested on Pro.2.3.14508 and could not repro a crash. I do notice that performance seems to have gotten slower using the latest version of the addin, so not sure if that might be related to the problems @BobBooth is seeing on just his machine.

dfoll commented 5 years ago

Pro 2.3.0.15723 CC 42 MT 176

I am experiencing a crash when I try to import a .csv

Airports.zip

Will try to get a newer build of Pro and post results here

This is not happening on ArcMap 10.3.1 with MT 176 or CC 42

kgonzago commented 5 years ago

confirmed Pro crashed when importing airports.csv. Looking into it now.

dfoll commented 5 years ago

installed Pro 2.3.0 (build 15768) (build number is no longer showing on About page)

This is still happening with Airports.csv (DMS) and MontereyPointsOfInterest.csv (MGRS)

kgonzago commented 5 years ago

I am able to consistently repro this issue in Pro 2.3 using the CSV file @dfoll attached in his comment. I narrowed it down to how the ambiguous dialog is instantiated during the import of coordinates from a CSV file. This line in a QueuedTask thread may be the issue.

@saip @CTLocalGovTeam Can you take a look at this issue?

lfunkhouser commented 5 years ago

@saip please provide an update on this issue. This is critical for the January release.

csmoore commented 5 years ago

Dev build created for QC at: Solutions\DefenseSolutions\CoordinateConversion\January2019\Dev\46

dfoll commented 5 years ago

Tested using CC 46 on Pro 2.3, the file @BobBooth provided and the files I provided are all working now for importing.

Tested using MT 183 on Pro 2.3, the file @BobBooth provided and the files I provided are all working now for importing. Testpoints.zip

Checklist test upated in 196 @lfunkhouser do we want to list this as an issue addressed, discovery and resolution of this issue all took place since the last release

Esri / coordinate-conversion-addin-dotnet

The coordinate Conversion add-in crashes Pro when importing a CSV file of coordinates #538

Current behavior:

Expected behavior: