Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

When importing files to Coordinate Conversion, persist fields from input #568

Closed dfoll closed 5 years ago

dfoll commented 5 years ago

Background

This is useful because all fields used from the input are lost once they are imported to CC. Not a big deal for fields that contain simple coordinate formats, as those can be added back in upon export by the CC pane, however those fields that are lost may contain non-coordinate attribute information, or highly customized coordinate notation.

Current behavior

Coordinate conversion imports from select file types. Only the coordinate fields are used by the CC pane. All other fields whether they are other coordinates or attribute data are lost.

Expected behavior

Coordinate Conversion holds all fields associated with a row/entry in memory while that point is in the Coordinate Conversion list.

[design doc tbd]

dfoll commented 5 years ago

@saip has asked when importing values from fields, what should be done about field type. because my understanding is that there is not a reliable one to one connection between excel data types and arcgis data types, i have given the answer that converting everything to strings will be ok for our first release/mvp

BobBooth commented 5 years ago

Can we mimic the behavior of (or reuse code from) the "Table to Table" GP tool? Seems as though Excel tables usually have a header row with text, so we could also look at the values further down the table to infer data type. The Incident Analysis sample data is in XLS format, and if you use Table to Table to import it to a GDB table (with default settings, no field mapping), it matches numeric fields to Double, Text to Text, and Dates to Date. IncidentsCopy.zip

MyProject85.gdb.zip

dfoll commented 5 years ago

Tested this in ArcMap and ArcGIS Pro. Good to merge PR. Should be added as What's New

dfoll commented 5 years ago

@saip i just noticed that importing a list with fields works properly. If you manually add to the list using the map point tool (so one point would have no details) and then export the list, none of the imported fields persist to the exported file

[UPDATE 13Mar 1650] issue #587 was created to address this in the future. #587 should be logged as a known issue, it also includes a workaround for the problem.

BobBooth commented 5 years ago

Doc changes visible in What's new, CC, and MT Release page on STG.