Provide checkbox to show +/- for custom formatting

[dfoll]

Current behavior

When a user is providing a custom format for DD/DMS/DDM they have the option to remove the N/S/E/W hemisphere designator from the coordinates. If the user does this, in the list, there is no indicator of what what hemisphere the coordinate is in.

Expected behavior

Provide checkbox in the custom formatting area for DD/DMS/DDM to "Show + for N/E hemisphere" and a checkbox to "Show - for S/W hemisphere"

Required for ArcMap 10.3.1 -10.7.1 and ArcGIS Pro 2.1 - 2.4

[saip]

@dfoll As per our discussion this morning, we are also implementing the case of hemisphere designators (N,S,E,W, n,s,e,w) also are not allowed to be added by user in the custom format textbox. Instead, user will be allowed to choose the display of hemisphere designators with a checkbox.

[dfoll]

@saip I have shown this work to the team and the team has this feedback:

• "Show N/S/E/W for hemisphere" should be on by default
• If "Show N/S/E/W for hemisphere" is checked, the top two should be grayed out
  • likewise if either "Show - for S/W hemisphere" or "Show + for N/E hemisphere" is checked, "Show N/S/E/W for hemisphere" should be grayed out.
  • From a code standpoint, would radio buttons work better for this? The point is "Show N/S/E/W for hemisphere" and "Show - for S/W hemisphere"/"Show + for N/E hemisphere" should be exclusive
• is it possible to have the preview area shown for "Advanced" update based on what is selected in thiese checkboxes/radio buttons

[dfoll]

I have spoken to @saip he has implemented exclusivity for "Show N/S/E/W" and "Show +/-" by making each of them a radio button. When you select the "Show +/-" radio button, the user will then have the option via checkboxes to "Show + for N/E" and/or "Show - for S/W"

@saip and crew will also provide a preview of what the coordinate string based on whichever radio button and/or checkboxes you have selected. There are two important caveat to this functionality that I am accepting for this release.

• if you have a radio button selected and do some custom formatting, the custom formatting will be lost if you switch to the other radio button. This is because each radio button comes with it's own preview string that is populated as a starting point when you select a radio button or checkbox.
• because the preview string cannot account for both N/E and S/W being shown in a single preview box
  • if the "Show +" checkbox is marked, the string will preview as
  • +Y0.0##### +X0.0#####
  • • if the "Show -" checkbox is marked, the string will preview as
  • -Y0.0##### -X0.0##### if both the "Show +" and "Show -" checkboxes both marked, the string will preview as
  • +Y0.0##### +X0.0#####

one change to this screenshot is that @saip with be adding a "/" between NSEW for the "Show NSEW" radio button.

[saip]

@dfoll If we implement as discussed in the comment above, preview string would stay static and would not be updated when user types in additional characters in the format textbox. The string would only be updated when user switches selection of radio buttons/checkboxes. So, as discussed yesterday we are implementing it without the caveat mentioned above. The implementation now would be

• Custom formatting will be retained even after switching selections of radio buttons/checkboxes
• Also, we are working on displaying "+/-" when both "Show +" and "Show -" checkboxes are checked (as discussed earlier).
  • if the "Show +" checkbox is marked, the string will preview as +Y0.0##### +X0.0#####
  • if the "Show -" checkbox is marked, the string will preview as -Y0.0##### -X0.0#####
  • if both the "Show +" and "Show -" checkboxes both marked, the string will preview as +/-Y0.0##### +/-X0.0#####

Preview string is placed as shown in the screenshot below

[dfoll]

@saip This looks good with three bugs i noticed, one minor, two significant

• [x] When user does not select any custom formatting, N/S/E/W are displayed for lat/lon coordinates
• [x] When custom formatting for lat/lon, you can show
  • [x] N/S/E/W as hemisphere indicators OR
  • [x] +/-
  • [x] the two choices are exclusive
• [x] When showing +- you can show
  • [x] + for N/E AND/OR
  • [x] - for S/W
• [x] A preview is show
  • [x] preview updates as the custom input box is edited

[dfoll]

@saip this is the minor bug i noted in the previous comment.

When you are using custom formatting and using either "Show N/S/E/W" or "Show +/-" when you switch the coordinate order to longitude latitude, the hemisphere prefix [or] suffix get confused about where they should be place and place themselves together on one end of the other of the coordinate pair.

Decimal degrees listed as lat/lon formatted to show +/- as hemisphere indicators - Correct!

Decimal degrees listed as lat/lon formatted to show N/S/E/W as hemisphere indicators - Correct!

Decimal degrees listed as lon/lat formatted to show +/- as hemisphere indicators - in the preview the prefix for both lon and lat are stuck together at the beginning of the coordinate pair

Decimal degrees listed as lon/lat formatted to show N/S/E/W as hemisphere indicators - in the preview the suffix for both lon and lat are stuck together at the end of the coordinate pair

[dfoll]

Two significant issues I found that i referenced in this comment

• one was unrelated to this work. @csmoore wrote up issue #619 and created a #620

@saip the second issue is a bit more in-depth and i believe is directly related to this work. The short version of the problem is we are seeing the same problem that was happening in #527 but seeing in on a smaller scale only with importing a list.

If I have custom formatting set and use the "Show - for S/W hemisphere" checkbox and import a list that has the coordinates formatted with a "-" already, to indicate Southern or Western hemisphere, there is some sort of double-negative math going on, and whatever coordinate was listed as a negative is becoming positive. In the case of the test date that is used for the repro steps that follow, the longitude values are all in the Western hemisphere and are written in the style of -121.84267250000,36.58915453010. The import happens successfully, but the points are placed incorrectly

Repro steps:

Test data: TabletoPoint_small.zip

CC build 145 I used ArcMap 10.7.1 because #620 has not been merged into CTLocalGovTeam-dev to fix #619 which makes reproducing with ArcGIS Pro difficult, but I seen the same thing there.

0. Open ArcMap with a basemap
1. On the Coordinate Conversion pane, click Edit Properties
2. Select DD > Custom
3. Select the Show +/- radio button
4. Select the Show - for S/W hemisphere checkbox
5. Click OK
6. Import the CSV listed as test data. Note, the longitude values in the test data are all listed as negative, meaning they should be in the Western hemisphere. This particular data should all be centered around Monterey, CA
7. Notice that when the points import, they are all placed off the shore of China in the Yellow Sea.

Additional info/speculation:

• I don't know exactly what is happening, but it seems like something happens that the add-in understands it should show a "-" for those values that are in the Western hemisphere/already have a negative, but before the points are placed i think a second negative gets applied, and some sort of weird double negative effect happens that the add-in then tries to place them after it thinks they are positive.
• the values that are imported that should be positive are not impacted in any way
• the same workflow imports and places points properly when "Show + for N/E hemisphere" is used
• the same workflow imports and places points properly when "Show N/S/E/W" is used

[lfunkhouser]

@CTLocalGovTeam do you have an update on this issue?

[dfoll]

@saip @CTLocalGovTeam tested CC build 151 built from this branch looks good. thanks!