Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

Crash when exporting to KMZ on ArcGIS Pro 2.3 #611

Closed dfoll closed 5 years ago

dfoll commented 5 years ago

Current behavior

A crash has been found by @CTLocalGovTeam involving exporting to KMZ and the Edit Properties button.

When you open a new project if you do not first open the Edit Properties window before exporting to KMZ, the KMZ you intend to export will not be created in the destination, and if you click the Edit Properties button after the export, ArcGIS Pro will crash.

Repro steps:

  1. Install ArcGIS Pro 2.3 + Military Tools 3.3.1

  2. Using Coordinate Conversion add some points to the map

  3. Click Export on the bottom of the Coordinate Conversion pane

  4. Select the KMZ radio button

  5. Give the KMZ a name and click save.

  6. Navigate in the catalog pane to the location where you saved the KMZ, note that the KMZ was not actually created.

  7. Click the Edit Properties button (on the Coordinate Conversion pane). ArcGIS Pro crashes

  8. Install ArcGIS Pro 2.3 + Military Tools 3.3.1

  9. Using Coordinate Conversion add some points to the map

  10. Open and close the Edit Properties window from the Coordinate Conversion window (do not need to actually change anything on the window, just open and close it).

  11. Click Export on the bottom of the Coordinate Conversion pane

  12. Select the KMZ radio button

  13. Give the KMZ a name and click save.

  14. Navigate in the catalog pane to the location where you saved the KMZ, note that the KMZ is created.

  15. Click the Edit Properties button (on the Coordinate Conversion pane). Crash listed above does not happen.

Additional notes:

Expected behavior

When exporting to KMZ the user should not need to open the Edit Properties window before trying to export.

dfoll commented 5 years ago

This was fixed in this commit by @CTLocalGovTeam team as part of the delivery for Coordinate Conversion

UPDATE: With dev build 113 I am still experiencing this crash UPDATE2: @saip has explained that somehow the changes that were included in the last delivery were overwritten. There has been another update to the CTLocalGovTeam-dev branch.

dfoll commented 5 years ago

CC build 114 seems to have this fix back in. @saip please consider include this issue as part of the upcoming CC delivery. When we test for merging that PR, we can close this issue

saip commented 5 years ago

@dfoll We are working on issue 600 updates we discussed this morning. We will raise a pull request soon.

csmoore commented 5 years ago

Tested on Pro 2.3 this seems to be resolved for the case where the points have been created by either (1) clicking on the map or (2) import from a file.

However it seems like if I mix/combine (1) map click points and (2) file import points in the output list. I either don't get a KMZ file created or I get an error.

NOTE: Issue #604 updated to include this case.

image

dfoll commented 5 years ago

Tested on ArcGIS Pro 2.3 with CC build 127 (created from this branch. Fix in #612 .

I cannot repro the problem with my original repro steps or @csmoore updated repro steps

dfoll commented 5 years ago

Added as a Issue addressed since it is something that was present in the last release

dfoll commented 5 years ago
lfunkhouser commented 5 years ago

Tested on MT dev 307 and CC dev 139 Verified on solutionsdev website