Closed lfunkhouser closed 4 years ago
@dfoll @lfunkhouser @csmoore @OscarVilla1
We have implemented code for following points:
Note: This build is work in progress and some build errors can be observed
@dfoll @lfunkhouser @csmoore @OscarVilla1
We have completed refactoring, and have committed the code for it.
Note: We have observed that addin is crashing in one case and we are working on it.
@lfunkhouser @csmoore @OscarVilla1@dfoll
Below are the repo steps to reproduce the crash we were experiencing:
We have found the root cause for this and have fixed at our end, and we are testing it.
@lfunkhouser @csmoore @OscarVilla1 @dfoll
We have pushed the code to fix the above mentioned crash.
@lfunkhouser @csmoore @OscarVilla1 @dfoll
We have pushed the code Pro Style changes.
@sumitzarkar - would it be possible to change the buttons also - like you did for DistanceAndDirection - thanks
@csmoore @dfoll @lfunkhouser
We have submitted the pull request for this ticket Pull Request Link
@csmoore will merge PR into a "Pro 2.6 branch"
@lfunkhouser @csmoore @dfoll
We have implemented the following code review comment and here is the commit link:
@lfunkhouser @csmoore @dfoll
We implemented code to fix pro style issue for browse window commit link:
✔️ These issues have been tested and closed (Dark Mode Form issues) : #647 , #648
The remaining issues are :
ViewModelBase
to PropertyChangedBase
- comment here: https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/646/commits/eff8118d3ece199b7831cf2ff861ef7427fec30c#r389223919@lfunkhouser @csmoore @dfoll
We implemented the code to combine duplicate Base Classes into one class/file (commit link):
Verified following fixes while running through Coordinate Conversion add-in Checklist located here https://github.com/ArcGIS/solutions-defense-test-catalog/issues/279
Verification was done using: ArcGIS Pro v.2.6.0 alpha build 23705 Coordinate Conversion add-in version attached to issue CoordinateConversion.zip
To prepare for converting the addin to a Pro-only component going forward, we are making some structural changes to the solution: