Closed sumitzarkar closed 4 years ago
I had a small build issue - not sure why it only showed up for me, but fixed in https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/645
I also now see that the Units Tests don't run because of the new Pro dependencies - I'll try to figure out how to get these tests running for acceptance (like maybe just put these tests - CoordinateConversion\CoordinateConversionLibrary.Tests
- in a quick addin just so we can run them)
@sumitzarkar Sorry for my delay reviewing this PR - @OscarVilla1 tested successfully and I think the only issue I noticed was that there are 2 base classes that could be combined into one class/file:
Opened alternate PR #646 - so we could just switch the head branch we are merging into (branch: Pro2.6 vs. dev). Feel free to move any discussion to that PR and sorry for any confusion.
Closing unmerged to merge into different head branch in PR #646
We have implemented code for following points: