search

Esri / coordinate-conversion-addin-dotnet

Addin for ArcMap and Pro for convenient coordinate conversion in Desktop.
Apache License 2.0
45 stars 20 forks source link

Separate ArcMap and ArcGIS Pro code #642 #646

Closed csmoore closed 4 years ago

csmoore commented 4 years ago

We are just switching the head branch we are merging PR #644 into (branch: Pro2.6 vs. dev).

Implements #642 Original PR: https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/644 (we will close this one unmerged after this PR is merged)

Original PR #644 comments from @sumitzarkar :

We have implemented code for following points:

  1. Removing: ArcMapAddinCoordinateConversion project/dll
  2. Removing:CoordinateConversionLibrary project/dll
  3. Refactoring the Pro project to remove dependencies on former CoordinateConversionLibrary a. remove view inheritance b. remove no-longer-needed classes (super/abstract classes) c. remove mediator/dispatcher (ex: convert to RelayCommands) d. use Pro styling for Dark Mode support
    1. As part of this if you notice any hard-coded UI strings that should be converted to Resources (for I18n) please convert these to resources
csmoore commented 4 years ago

@sumitzarkar We have finished our review and testing, the only remaining issues to close and merge this PR is:

Combined duplicate Base Classes into one class/file:

  1. TabBaseViewModel and ProTabBaseViewModel
  2. OutputCoordinateViewModel and ProOutputCoordinateViewModel

[NEW] A couple of Dark Mode Form issues:

  1. 647

  2. 648

sumitzarkar commented 4 years ago

@csmoore

Combined duplicate Base Classes into one class/file: TabBaseViewModel and ProTabBaseViewModel OutputCoordinateViewModel and ProOutputCoordinateViewModel

We are working on this.

csmoore commented 4 years ago

@sumitzarkar -as we discussed I added 2 more dark mode issues to the list above

csmoore commented 4 years ago

@sumitzarkar We have finished our review and testing, the only remaining issues to close and merge this PR is:

Combined duplicate Base Classes into one class/file:

TabBaseViewModel and ProTabBaseViewModel OutputCoordinateViewModel and ProOutputCoordinateViewModel [NEW] A couple of Dark Mode Form issues:

647

648

csmoore commented 4 years ago

✔️ These issues have been tested and closed (Dark Mode Form issues) : #647 , #648

So only remaining issues are :

  1. Combined duplicate Base Classes into one class/file: TabBaseViewModel and ProTabBaseViewModel OutputCoordinateViewModel and ProOutputCoordinateViewModel
  2. Change a few base class objects from ViewModelBase to PropertyChangedBase - comment here: https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/646/commits/eff8118d3ece199b7831cf2ff861ef7427fec30c#r389223919
csmoore commented 4 years ago

Successfully tested - merging