Closed csmoore closed 4 years ago
@sumitzarkar We have finished our review and testing, the only remaining issues to close and merge this PR is:
Combined duplicate Base Classes into one class/file:
[NEW] A couple of Dark Mode Form issues:
@csmoore
Combined duplicate Base Classes into one class/file: TabBaseViewModel and ProTabBaseViewModel OutputCoordinateViewModel and ProOutputCoordinateViewModel
We are working on this.
@sumitzarkar -as we discussed I added 2 more dark mode issues to the list above
@sumitzarkar We have finished our review and testing, the only remaining issues to close and merge this PR is:
Combined duplicate Base Classes into one class/file:
TabBaseViewModel and ProTabBaseViewModel OutputCoordinateViewModel and ProOutputCoordinateViewModel [NEW] A couple of Dark Mode Form issues:
✔️ These issues have been tested and closed (Dark Mode Form issues) : #647 , #648
So only remaining issues are :
ViewModelBase
to PropertyChangedBase
- comment here: https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/646/commits/eff8118d3ece199b7831cf2ff861ef7427fec30c#r389223919Successfully tested - merging
We are just switching the head branch we are merging PR #644 into (branch: Pro2.6 vs. dev).
Implements #642 Original PR: https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/644 (we will close this one unmerged after this PR is merged)
Original PR #644 comments from @sumitzarkar :
We have implemented code for following points: