Esri / crowdsource-reporter

An ArcGIS Online group application template authored by organization and made available to constituents to report a problem or observation.
http://solutions.arcgis.com/local-government/help/crowdsource-reporter/
Apache License 2.0
25 stars 32 forks source link

BUG-000134502 ArcGIS World Geocoding Service does not provide proper suggestions in Crowdsource Reporter apps #497

Closed aparveen closed 3 years ago

aparveen commented 3 years ago
aparveen commented 3 years ago

Reporter CrowdsourceReporter_suggestions Basic Viewer BasicViewer_Suggestions

ashishchoure commented 3 years ago

@aparveen

Please let us know your thoughts.

aparveen commented 3 years ago

@ashishchoure please proceed with this change, could you please make this one separate delivery from the other fixes, so if there is any issue with the code we can pull it back?

ashishchoure commented 3 years ago

@aparveen

ashishchoure commented 3 years ago

@aparveen

We have analyzed the issue and here are the two approaches:

1. Replace the custom Search with ArcGIS JS API Search widget

2. Add suggestion capabilities inside the custom Search widget

Additional Notes:

As per our discussion on yesterday's call, we decided to go ahead with Approach 2. This will have a minimum impact on the application.

Please let us know your thoughts.

ashishchoure commented 3 years ago

Dev Checklist

Items ​ Is required​ Status Comments​
Required NLS change?​ No  
Required Backward compatibility​? No    
Required 508​? No    
Need Sanitize?​ No

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes?​ No
Have Runtime changes?​ Yes
Impact on RTL No
Geocoding Service With Suggest Capability
  • All the geocoding services with suggest capability should show suggestions in the collapsable list
  • The configurable parameter such as name, maximum suggestions, search within map extent, enable suggestions should be honored while showing suggestions
  • Correct address should be shown on the map once a user clicks on any of the suggestion
  • Geocoding Service Without Suggest Capability
  • Geocoder without suggest capability should continue to work the same ways as per the current implementation
  • Layer Search
  • If any of the layers is search enabled then the layer search should continue to work the same ways as per the current implementation and the feature should be shown in the list
  • aparveen commented 3 years ago

    @ashishchoure in Android phone and table, the suggestion is not working as expected. If I start to type, suggestions do not show up right away, after finish typing, if I delete a few alphabets, then it starts to show up. Could you please take a look?

    ashishchoure commented 3 years ago

    @aparveen

    aparveen commented 3 years ago

    Thanks @ashishchoure for looking into this issue.

    aparveen commented 3 years ago

    verified in qa