search

Esri / crowdsource-reporter

An ArcGIS Online group application template authored by organization and made available to constituents to report a problem or observation.
http://solutions.arcgis.com/local-government/help/crowdsource-reporter/
Apache License 2.0
25 stars 32 forks source link

Uncaught TypeError reading 'showDialog' #513

Closed skrishn closed 2 years ago

skrishn commented 3 years ago

I have the help option disabled and I noticed a console error on this app.

Error: image

https://localgovqa.mapsqa.arcgis.com/apps/CrowdsourceReporter/index.html?appid=31bdc370c3114adea7628d7c7a6f0a81

sumitzarkar commented 3 years ago

@skrishn

In the configuration help is disabled but showHelpOnload is true which is causing this issue

image

On Load application checks if showHelpOnload is true it shows the help dialog but in this case help is not enabled.

Here is the code which is executed on load image

Solution:

  1. from configuration set showHelpOnload to false if help is disabled
  2. We can update the condition to check if help is enalbed and showHelpOnload is true then only it will shows the help on load image
skrishn commented 3 years ago

@sumitzarkar : Thanks for looking into this. Let's fix this for 9.4

cc @aparveen

skrishn commented 2 years ago

verified in qa