If logged in user doesn't have a first or last name in their profile, the form will fail to load if the app is configured to auto-populate fields using this information

Esri / crowdsource-reporter

An ArcGIS Online group application template authored by organization and made available to constituents to report a problem or observation.

http://solutions.arcgis.com/local-government/help/crowdsource-reporter/

Apache License 2.0

25 stars 32 forks source link

If logged in user doesn't have a first or last name in their profile, the form will fail to load if the app is configured to auto-populate fields using this information #532

Open chris-fox opened 2 years ago

chris-fox commented 2 years ago

This issue is related to #512. I hit this issue during testing in Enterprise, I was using a portal with IWA. I deployed Citizen Problem Reporter and logged-in using my esri account. When I attempted to submit a new report the form was blank and there were a couple console errors.

I found through troubleshooting that in the portals/self request that my logged in user did not have a first or last name, but the app had been configured to pull the first and last names of the logged in user into the form. It appears we are not checking if the properties exist on the user profile and is throwing an exception. It is difficult to replicate this because the UI doesn't allow you to create an account without a first and last name.

However, if you use on of the Enterprise 11 release machines with IWA authentication and deploy Citizen Problem Reporter you should be able to reproduce the issue.

aparveen commented 2 years ago

@sumitzarkar could you please assess the level of effort to fix this issue?

sumitzarkar commented 2 years ago

@aparveen

We are not able to reporduce this case with AGOl / Portal users as it is not allowing to create users without or empty FirstName and Lastname.
As mentioned in the ticket this issue is observed when using a portal with IWA
It would be helpful if we get the screenshots of the console errors or if possible the application to reproduce this issue

chris-fox commented 2 years ago

I unfortunately added my firstName and lastName to my user when testing and can no longer reproduce. It is really easy to reproduce in debug though, just remove the firstName or lastName property from the user object returned from REST.

sumitzarkar commented 2 years ago

@chris-fox @aparveen

We are able to repro the case after deleting firstName and lastname from the object and we have fixed this issue. Currently we are testing it and will deliver the code early next week.

sandhyakurumanale-ct commented 2 years ago

@aparveen

Dev Checklist

Items	Is required	Status
Required NLS changes?	No	-
Required Backward compatibility	No	-
Required 508	No	-
Need Sanitize?	No	-

Impact Analysis Report

Impacted Areas	Comments
Have Configuration changes?	No
Have Runtime changes?	Yes
Impact on RTL	No
Runtime impacts	1. If the logged-in user doesn't have a first or last name in their profile and the app is configured to auto-populate fields with user information(first or last name), the form should load successfully. 2. Test in the geo form. 3. Test in the comment form.