search

Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
23 stars 8 forks source link

Preview Values prints 1.0 on numeric field if value is "" #153

Closed SteveGrise closed 7 years ago

SteveGrise commented 7 years ago

string value of empty string is 1

SteveGrise commented 7 years ago

Actually the value was being overwritten by later valuemap values even if there was a match in the data grid. Change to only set to Otherwise value if no match found.

SteveGrise commented 7 years ago

Also fix domain map preview to show the source value if no matching map value found.

previnWong commented 7 years ago

Preview shows "" now instead of 1. image

But if I run the preview command, I get an error image

SteveGrise commented 7 years ago

setvalue is blank, that's what I'd expect to see for a number field

On 28 Mar 2017 7:07 p.m., "Previn Wong" notifications@github.com wrote:

Preview shows "" now instead of 1. [image: image] https://cloud.githubusercontent.com/assets/11183838/24431398/81054cec-13d0-11e7-91cb-9a2725284209.png

But if I run the preview command, I get an error [image: image] https://cloud.githubusercontent.com/assets/11183838/24431407/9132ec28-13d0-11e7-8cda-2ac32c8214c8.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Esri/data-assistant/issues/153#issuecomment-289932201, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh3BB-q8AhLhyxrS7XiHB_qFGdMn374ks5rqZKagaJpZM4MrsZL .

previnWong commented 7 years ago

The errors are valid, since the field is required and it's an integer, just wondering if the messaging is is not user friendly. Ot just do a simple data type check and return a friendly message right away.

SteveGrise commented 7 years ago

Yes, Preview Values could do type checking.

On Wed, Mar 29, 2017 at 11:28 AM, Previn Wong notifications@github.com wrote:

The errors are valid, since the field is required and it's an integer, just wondering if the messaging is is not user friendly. Ot just do a simple data type check and return a friendly message right away.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Esri/data-assistant/issues/153#issuecomment-290126702, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh3BL0CcRFWnCM4sGvNzcFASSDTiYr8ks5rqniBgaJpZM4MrsZL .

previnWong commented 7 years ago

initial issue is fixed. UI could show better message for type cast error, but closing since UI is minor