search

Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

Bug - When source or target has no fields, source-target errors #160

Closed MikeMillerGIS closed 7 years ago

MikeMillerGIS commented 7 years ago

1: Create a new polygon layer, do not add any fields 2: Create a new source-target file

image

SteveGrise commented 7 years ago

It's a nonsense use case but should not raise an error now.

pLeBlanc93 commented 7 years ago

What's the point in creating the XML file? Should error out similarly to 

Running script SourceTargetMapping...
Source: C:\Users\Win10\Desktop\MyProject\PostgreSQL - a417_water.sde\a417_water.un.UtilityNetwork\a417_water.un.WaterAssembly
Target: C:\Users\Win10\Desktop\MyProject\PostgreSQL - a417_water.sde\a417_water.un.UtilityNetwork\a417_water.un.WaterAssembly
File: C:\Users\Win10\Desktop\MyProject\pls.xml
2 string layers with the same value is not supported by this tool, please rename one of the layers, exiting.
Completed script SourceTargetMapping...
Failed to execute (SourceTargetMapping).
SteveGrise commented 7 years ago

No thanks, it's a nonsense use case and I'm not going to debate whether it's an error or not, we don't want the script to error out with a python error.

On Fri, Apr 21, 2017 at 6:11 PM, Paul LeBlanc notifications@github.com wrote:

What's the point in creating the XML file? Should error out similarly to

Running script SourceTargetMapping... Source: C:\Users\Win10\Desktop\MyProject\PostgreSQL - a417_water.sde\a417_water.un.UtilityNetwork\a417_water.un.WaterAssembly Target: C:\Users\Win10\Desktop\MyProject\PostgreSQL - a417_water.sde\a417_water.un.UtilityNetwork\a417_water.un.WaterAssembly File: C:\Users\Win10\Desktop\MyProject\pls.xml 2 string layers with the same value is not supported by this tool, please rename one of the layers, exiting. Completed script SourceTargetMapping... Failed to execute (SourceTargetMapping).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Esri/data-assistant/issues/160#issuecomment-296317249, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh3BKh9jJ34FQ_1n52JdIkIlwO8_4Vsks5rySmFgaJpZM4NDVO5 .

ChrisBuscaglia commented 7 years ago

Closing this issue.