search

Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

Using a layer from the TOC for a feature service - does not work - source to target #165

Closed MikeMillerGIS closed 7 years ago

MikeMillerGIS commented 7 years ago

This service is not shared with everyone and is using https

image

MikeMillerGIS commented 7 years ago

fyi @ChrisBuscaglia

MikeMillerGIS commented 7 years ago

using the url works fine image

SteveGrise commented 7 years ago

I'm not even sure how you added that - is the item a layer you selected from the combobox? I suspect there is something strange going on with the datasource property testing/concatenation... and http/https in the code

SteveGrise commented 7 years ago

@MikeMillerGIS can you open up that service and send me the url in text form? I'm puzzled about the Service Name result and the http://https:// at the start of the url in the error message.

MikeMillerGIS commented 7 years ago

Add any hosted FS to your TOC from the portal page. That shows up in the drop down.

MikeMillerGIS commented 7 years ago

here is what is passed in Stormwater_OpenDrain_5015368ed0dc4f75a2103bb8dc7b3208\Storm Open Drains

source props image

SteveGrise commented 7 years ago

Can you send me that long url in text form?

MikeMillerGIS commented 7 years ago

https://services3.arcgis.com/xoil9QbyeUaxAZtF/arcgis/rest/services/Stormwater_OpenDrain_5015368ed0dc4f75a2103bb8dc7b3208/FeatureServer

SteveGrise commented 7 years ago

@ChrisBuscaglia @MikeMillerGIS this will need re-testing. I am not sure this fixes the issue, but it should at least provide a better error message. The key part of the error message is: image

I am not able to reproduce that message, but I made 2 changes in the service name and layerid functions the I think addresses it.

SteveGrise commented 7 years ago

see the funny http://https:// part of the url in the error message above...

MikeMillerGIS commented 7 years ago

will test today

previnWong commented 7 years ago

@SteveGrise , the issue is still there. make sure that you are using a https, http works fine. image

SteveGrise commented 7 years ago

Ahh, there's a clue here - GIS Servers\https:// at the beginning seems to trip it up. Will take another look.

SteveGrise commented 7 years ago

Made a small update today to ensure string handling - found an issue using https AGO tables.

ChrisBuscaglia commented 7 years ago

@previnWong can you please verify this?

previnWong commented 7 years ago

@SteveGrise @ChrisBuscaglia Seems to be working now for https feature services. will test tables next.

ChrisBuscaglia commented 7 years ago

Tables look OK from testing on my end - closing this issue.

previnWong commented 7 years ago

@ChrisBuscaglia Are you seeing this behavior with the tables?

If I drag the FS into the TOC. If I drag the table from TOC into the DA tool, it throws an error. image

image

If I drag the FS table from portal into the DA tool, then it stores the path correctly. image

I know we got into a discussion about the tables not being in the drop down to select from and that it will not be addressed, but if I drag it from the TOC, shouldn't it still store the path? Feel free to close if this is normal expected behavior, does not seem like it to me.

previnWong commented 7 years ago

putting this known behavior in the wiki

ChrisBuscaglia commented 7 years ago

@previnWong if you navigate to the table via the browse... button does it work?

previnWong commented 7 years ago

@ChrisBuscaglia Browse to table (works) Drag from portal pane (works) Drag from Content pane (error)

ChrisBuscaglia commented 7 years ago

@previnWong @SteveGrise @MikeMillerGIS @jessnoo spoke with GP team - TableView is for tables and table views and is the preferred (and recommended) way to accept feature service tables. Added an issue for the next version to be delivered over the summer with ArcGIS Pro 2.0.

https://github.com/Esri/data-assistant/issues/166

previnWong commented 7 years ago

closing this since #166 is created.