Append/Replace tool completes without error when target fields are too short, no data gets added

Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.

Apache License 2.0

22 stars 8 forks source link

Append/Replace tool completes without error when target fields are too short, no data gets added #170

Open ChrisBuscaglia opened 7 years ago

ChrisBuscaglia commented 7 years ago

Append/Replace tool completes without error when target fields are too short, no data gets added. This may be specific with feature services as targets. Reported by City of Salt Lake, UT.

Should at least provide a warning (skip copy of long chars.)

Workaround - make all target fields 255.

ChrisBuscaglia commented 7 years ago

@JRosenfeldIntern can you add this to your backlog?

JRosenfeldIntern commented 7 years ago

@ChrisBuscaglia not sure I follow.

Lets say source = String(255) target = String(2)

If the source value was "Hello", it would map to "He". If this is the case, we should warn for truncation. Is that correct? Or is it all or nothing ("Hello" -> Null)?

ChrisBuscaglia commented 7 years ago

@JRosenfeldIntern I'll have to retest, seems like we aren't doing any truncation as the tool stands now.

JRosenfeldIntern commented 7 years ago

@ChrisBuscaglia having a hard time re-creating this one.

When I tried to pass a 255 into a length 2 text field, it fails for me and gives me this error