Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

Domain Map - Ability to add a new code #186

Open MikeMillerGIS opened 7 years ago

MikeMillerGIS commented 7 years ago

Feedback from services is that the domain map needs the ability to add a new row. As part of the mapping if the user identifies a code is not in the target, they will need to add it to the target GDB. They would not want to break out of the data translation mapping process, but have the ability to add a new row, where they would manually specify the target value in which they would add at a later date.

As an option, we could expose the ability to add the code to the target GDB also. This would call Add Code to domain.

@pLeBlanc93 @previnWong @ChrisBuscaglia

previnWong commented 7 years ago

@JRosenfeldIntern is looking into this. @chris-fox has logic in there in the deployment tool, need similar functionality in DA.

MikeMillerGIS commented 7 years ago

We would not add the code to the target schema, we just need the ability to add a row and value in the conversion.

Sent from my Verizon Wireless 4G LTE DROID

JRosenfeldIntern commented 7 years ago

I've already implemented something along those lines. Essentially you can enter a value in a text field and it appears as an option as a source or target domain in the drop down field. It's still a bit buggy and the workflow isn't great, still working on that. Here's what the UI looks like at the moment. step1 step2 step3

previnWong commented 7 years ago

I think we should enhancement the settings pane and give them that option to add coded value to domain. If they already know they need a domain in the target because their source has it and they forgot to add it in the target when it was made, we should be able to add to the domain. That's better than having the value in the xml and then adding the coded value to target at a later time.

JRosenfeldIntern commented 7 years ago

@previnWong wouldn't, at that point, they be able to go into the target data and add a domain through the traditional means? Or is it more of an ease of access?

MikeMillerGIS commented 7 years ago

In terms of the UN, should they really add that in an asset package. I think an option to run add code to domain would be nice, just not a default setting.

Sent from my Verizon Wireless 4G LTE DROID

previnWong commented 7 years ago

@JRosenfeldIntern more ease of access, I just overhead Ben Nadler at the UC, saying not having the users jump around. @MikeMillerGIS for the UN, I agree, the missing coded value should be added to AP and run to add the increment. just thinking overall as an ETL tool, it should probably have that adding domain as part of its capabilities.

MikeMillerGIS commented 7 years ago

Make sense. Just need to be able to handle Feature Service and Local gdb layers.

pLeBlanc93 commented 7 years ago

You open a can of worms with adding domains to the target. Someone will want to add a range domain, then a field, maybe a subtype, etc. I see the appeal for an ETL tool though.

I'd suggest serializing the GP calls and instructing the user to run instead of us doing it for them.

pLeBlanc93 commented 7 years ago

You'd also need to account for shapefiles/dbf and disable accordingly