Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

Request to implement 11 bug fixes/enhancements #219

Closed JRosenfeldIntern closed 7 years ago

JRosenfeldIntern commented 7 years ago

Pull request implementing

185 - Preview not working properly for ConditionalValue method

193 - Data Mapper now uses ArcGISPro dialog box to open xml files

194 - Data Mapper now behaves like other (2.0) GPTools. You can now also drag xml files into the load textbox as opposed to having to search for them through the dialog box.

203 - Source Value now pre-loads when domain mapping as opposed to target

217 - GPTools were not parsing the .sde correctly from layer files

205 - Subtypes would be swapped when reloading domain mapping

206 - UpdateCursor would fail but continue. Now stops immediately and prints a useful error

207 - Added more tracebacks throughout the scripts. Still not perfect, but a step forward

210 - Implemented a solution that completely removes the Apply button. All changes made in Data Mapper are immediately reflected in the xml.

213 - GPTool no longer maintains attachments. Sources with attachments will not cause append to crash.

214 - Adding a 'GlobalID' type field to the intermediate data is now no longer allowed. Converts to GUID.

I have tested each one of these, but it might be good to test them on 1.4 and verify they work as I developed them in 2.x.

MikeMillerGIS commented 7 years ago

Josh, can you resolve the conflicts?

JRosenfeldIntern commented 7 years ago

Sorry, conflicts resolved. @MikeMillerGIS