search

Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

Subtype Fields Domain Preview not working #223

Closed JRosenfeldIntern closed 7 years ago

JRosenfeldIntern commented 7 years ago

In Domain Mapping, the source rows lay out all different domain values across all subtypes. In order for the preview rows underneath that mapping to show honestly, you would have to change the value in it's last iteration within the rows. For instance:

Here is an example of the layout if the source was a subtype field with domains A and B. 0 (A) - (None) 1(A) - (None) 0 (B) - (None) 1 (B) - (None)

If all of the values in source are 1, then mapping either 1(A) or 1(B) should do the same thing. The preview row, however, will not show the accurate mapping unless you map it to 1(B) due to a for loop that does not break.

JRosenfeldIntern commented 7 years ago

I rewrote the way the preview works. This issue will no longer occur and i have reduced the time complexity from quadratic to linear.

Will be in the next pull request.

pLeBlanc93 commented 7 years ago

Constant time or bust.