Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

Domain Mapping rework Testing #249

Open ChrisBuscaglia opened 6 years ago

ChrisBuscaglia commented 6 years ago
chris-fox commented 6 years ago

Every time I click the Load Domains button it adds the layers for the source and target to the map. I understand this is because of a limitation we encountered with get the domain from the feature class in the Pro .NET api. However, it seems necessary to have to add the layer (resulting in duplicate copies of the layer) every time to button is clicked. It might not make sense to click the button multiple times for the same field, but perfectly reasonable workflow if you have multiple fields with domains.

chris-fox commented 6 years ago

More of a question because I expected different results, but if a value doesn't have a corresponding value in the domain target and you leave it set to (None) should the value still be copied? See the example below where in the source the Domain has a code of 1, description Monday. If I leave the target set to None, I would expect any values of 1 to be set to null when appended to the target source. However, what I am seeing is the value of 1 is written to the target even though that value doesn't exist in the target Domain. It behaves more like Copy in this sense.

image

MikeMillerGIS commented 6 years ago

I think it does act as a copy, so a code unmapped copies as is.

chris-fox commented 6 years ago

Related to my first comment above, once I have loaded the domains and set the mapping if above I select another field from the table above and then re-select the field with the domain mapping I triggers both layers to be loaded into the map again. It seems like we could read these values into memory rather than having to load the layers each time.

chris-fox commented 6 years ago

Other than the comments above everything functioned well and I was able to map between domains successfully.