search

Esri / data-assistant

ArcGIS Pro Add-in that assists in emergency management, local government and state government data aggregation workflows.
Apache License 2.0
22 stars 8 forks source link

When target is eGDB, map doesn't refresh as expected #89

Closed jessnoo closed 7 years ago

jessnoo commented 7 years ago

i have observed this with feature services as well. I'm not sure if this is a Pro thing, or if there is a way we could address it with the tools.

Repro steps:

  1. Build a new mapping file fgdb - egdb. Use the map layer for the egdb at least.
  2. Execute append

Notice that the map does not refresh to include the new data loaded. I have to reload the map for the data to show up at the scale which the tool was run image

jessnoo commented 7 years ago

Similar issue with Replace ...

image

SteveGrise commented 7 years ago

I have tried several approaches. Typically what I see is that the portion of the map that was displayed at a certain scale is erased after Append Data, but Replace Data correctly updates the screen.

If you mouse-scroll out or in the screen contents are correct, but that scale is not displayed. If you pan left/right there are gaps in the screen as shown below:

image

image

The second screen contents only appear after I select f5 - I cannot find a programmatic way to refresh the screen. I tried several things with map cach settings on the target layer and resetting layer properties to try to force the screen update.

Will try again with Alpha 4, but not coming up with many ideas on how to resolve this issue.

SteveGrise commented 7 years ago

Repro case: Use GP DeleteRows Use Data Assistant Append Data The layer updated in the current map extent at the current scale is not updated, but if you zoom in and out it will refresh.

chris-fox commented 7 years ago

You could explore setting the layer/feature class as a derived output of the tool. I believe GP notifies the map in this case that the layer/feature class is being modified in that case.

SteveGrise commented 7 years ago

​I see 2 problems with that:

  1. The tools are set up to accept multiple input files, I suppose the derived layer would only be the final target layer
  2. In an earlier version I had it set up like this, and the added the layer(s) to the map even if it was already there. I think I had some feedback that this was undesirable but could check on the behavior again.​

On Tue, Nov 22, 2016 at 4:27 PM, Chris Fox notifications@github.com wrote:

You could explore setting the layer/feature class as a derived output of the tool. I believe GP notifies the map in this case that the layer/feature class is being modified in that case.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Esri/data-assistant/issues/89#issuecomment-262370818, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh3BPkFjLCtwR_mjGJHwxpOb4pViPM7ks5rA15YgaJpZM4Ks-zs .

chris-fox commented 7 years ago

For the first item you can set a derived output parameter to be a multivalue, so this should work for multiple input files. For the 2nd item I can't speak for the rest of the team, but i just think this is the way GP tools work and we should just go with it.

SteveGrise commented 7 years ago

Ok, will set it up to test.

On 23 Nov 2016 9:12 a.m., "Chris Fox" notifications@github.com wrote:

For the first item you can set a derived output parameter to be a multivalue, so this should work for multiple input files. For the 2nd item I can't speak for the rest of the team, but i just think this is the way GP tools work and we should just go with it.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Esri/data-assistant/issues/89#issuecomment-262522572, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh3BOJk3lZGrqIWPDmBxz3gCBtREUPLks5rBEnlgaJpZM4Ks-zs .

ChrisBuscaglia commented 7 years ago

@SteveGrise any updates on this one, anything for us to retest?

SteveGrise commented 7 years ago

I'm reluctant to make a functional change in the tools based on a screen refresh bug plus a lack of a 'redraw map' function in Pro.

I'm also not convinced it will solve the issue and/or create additional issues.

On 28 Nov 2016 10:51 a.m., "Chris Buscaglia" notifications@github.com wrote:

@SteveGrise https://github.com/SteveGrise any updates on this one, anything for us to retest?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Esri/data-assistant/issues/89#issuecomment-263342410, or mute the thread https://github.com/notifications/unsubscribe-auth/AEh3BDr-HvEr7sebXGgVla90DNUupZfPks5rCxS5gaJpZM4Ks-zs .

SteveGrise commented 7 years ago

This does appear to update the map layers. Note it does add layers to the map for Append and Replace now, this is a small functional change but avoids the refresh issue in testing.