search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

MapViewMode improvements. #103

Closed esreli closed 6 years ago

esreli commented 6 years ago

This PR improves MapViewController's mapViewMode property.

First, MapViewMode case .selectedFeature now permits an input variable featureLoaded: Bool. This gives checking state more accurate when there is a selected feature but it hasn't loaded it's related records yet.

Second, this PR decouples automatically updating mapViewMode after setting currentPopup. This gives us a finer degree of control over managing the UI.

NOTE* I have no idea why the changes to the README (and subsequent new image files) made it into this PR. If you look at the development branch, you'll see they are already there and in this condition.

esreli commented 6 years ago

I've addressed your only request and because of time, i'll be merging this request. Feel free to re-open should you find more.