search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Some changes from the review. #113

Closed nixta closed 6 years ago

nixta commented 6 years ago

I know you wanted them just committed direct, but I started collecting them here and it just made sense for some reason to make a PR :)

Let me know what you think. It's mostly just edits to the voice really.

One note: The initial description on a function should be more declarative and succinct - in places you go straight into a sometimes chatty description and the lede tends to get buried. I also felt we could use the markup better in places.

All minor stuff - it's looking really good so far.

nixta commented 6 years ago

P.S. Go ahead and merge once you've given it a once over, assuming you approve of course.