Modifies origin directly rather than through a helper method

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.

https://developers.arcgis.com/

Apache License 2.0

25 stars 26 forks source link

Modifies origin directly rather than through a helper method #127

Closed philium closed 6 years ago

philium commented 6 years ago

Also removes related unused helper methods on CGRect and CGPoint.

philium commented 6 years ago

Is there a reason you chose to leave in func modified(x xDelta: CGFloat) -> CGPoint ?

I checked that CGPoint.modified(y:) was being used and just assumed the other one was being used as well.

esreli commented 6 years ago

I left it because it felt more balanced, despite not being used. If the app provides an API for interacting with CGPoint in such a way for y, it should do the same for x. I would still suggest it stays. Was just curious why you hadn't nixed it like you did the other APIs.

philium commented 6 years ago

Agreed.