Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Improves Accessibility #148

Closed esreli closed 5 years ago

esreli commented 5 years ago

This PR enhances the accessibility of the app through dynamic font, content size and higher contrast colors.

When solving for dynamic font size, a number of concerns are raised. At a font that is largest, can all of the content be read? Will certain UI elements cover others?

With colors, other concerns are raised. How does the app look for those with varying degrees of color blindness?

Note As a result of the need to change the app's colors, I decided to lump the accessibility issue with the global appearance issue. This way, I could change colors throughout the app as I worked on color accessibility.

To see the app at various levels of dynamic font size, open the Accessibility Inspector and attach it to the process running the app. Then, click the cog icon and adjust the Font size slider. Note: UIButtons don't automatically adjust for content size changes like labels do. The best way to test UIButtons at various sizes is to re-run the application with a different font size.

Testing considerations

AppContainerViewController

MapViewController

DrawerViewController

PopupRelatedRecordsViewController

JobStatusViewController

esreli commented 5 years ago

@philium i've addressed some of your comments. Have a look?